Skip to content

Conversation

@Anon1234
Copy link
Contributor

No description provided.

@acrisci
Copy link
Member

acrisci commented Oct 25, 2015

Can you use dashes instead of underscores in the file name to make it consistent with the other examples?

@Anon1234
Copy link
Contributor Author

Done.

@acrisci
Copy link
Member

acrisci commented Oct 26, 2015

It should fail nicely if xprop is not found with a message to install it. Maybe check check_output for 127 and print the message there. Also, the dependency should be documented somewhere.

@Anon1234
Copy link
Contributor Author

Done. Is there anything else to improve?

@acrisci
Copy link
Member

acrisci commented Nov 1, 2015

Seems to work ok.

Thanks for the example 👍 .

acrisci pushed a commit that referenced this pull request Nov 1, 2015
Add focus_next_visible.py example
@acrisci acrisci merged commit 7279f34 into altdesktop:master Nov 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants