[feat] 내가 지원한 가게 목록 필터링 로직 수정 및 UI 개선#52
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughApplicationStatus 타입과 필터 매핑이 submitted/accepted/rejected/cancelled 중심으로 재구성되었습니다. 훅(getCardStatus, selectedFilter), 배지(BADGE_STYLE_MAP) 및 리스트·카드 컴포넌트 타입이 일치하도록 정렬되며, 관련 페이지들에 UI·렌더링 조정이 적용됩니다. ChangesApplication Status Refactoring & Filter Consolidation
🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed due to a network error. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/features/user/home/applied-stores/hooks/useAppliedStoresViewModel.ts`:
- Around line 31-35: getCardStatus currently maps all cancellation-related
ApplicationStatus values to 'rejected', causing CANCELLED/EXPIRED/DELETED to
display as "불합격"; update getCardStatus to distinguish cancelled from rejected by
adding a distinct return value (e.g., include 'cancelled' in the return union)
and map the specific ApplicationStatus values (cancelled/expired/deleted) to
that new 'cancelled' badge while keeping real rejections as 'rejected'; also
ensure ApplicationStatusBadge (or wherever card badges are rendered) knows how
to render the new 'cancelled' variant so the UI shows "취소됨" separately from
"불합격".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2303b04f-a132-4d2d-92da-719d8a56bfc7
📒 Files selected for processing (11)
src/features/user/home/applied-stores/hooks/useAppliedStoresViewModel.tssrc/features/user/home/applied-stores/types/application.tssrc/features/user/home/applied-stores/types/appliedStore.tssrc/features/user/home/applied-stores/ui/AppliedStoreCard.tsxsrc/features/user/home/applied-stores/ui/AppliedStoreList.tsxsrc/features/user/home/applied-stores/ui/AppliedStoreListItem.tsxsrc/pages/manager/home/index.tsxsrc/pages/notification/index.tsxsrc/pages/user/applied-stores/index.tsxsrc/pages/user/home/index.tsxsrc/shared/ui/home/ApplicationStatusBadge.tsx
kim3360
approved these changes
Jun 12, 2026
limtjdghks
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ID
변경 내용
구현 사항
구현 시연 (필요 시)
2026-06-12.9.29.05.mov
2026-06-12.9.46.36.mov
참고 사항 (필요 시)
Summary by CodeRabbit
New Features
Improvements
Style
Refactor