[fix] 사장님 메인 매장 목록 아이콘 수정#53
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthrough
Changes배너 아이콘 교체
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/pages/manager/home/index.tsx (2)
27-327: 🛠️ Refactor suggestion | 🟠 Major | 🏗️ Heavy liftpages 레이어 지침 위반: 비즈니스 로직 포함 및 코드 스플리팅 누락
코딩 가이드라인에 따르면 pages 레이어는 조합(Composition)만 해야 하는데 현재 다음 문제가 있습니다:
- 비즈니스 로직 포함: 퇴사 처리 상태 관리(L30-33, 58-59)와 mutation 로직(L306-314)이 페이지에 직접 구현되어 있습니다. 이는 features/widgets 레이어로 분리되어야 합니다.
- 코드 스플리팅 누락: React.lazy/Suspense를 통한 페이지 레벨 코드 스플리팅이 적용되지 않았습니다.
- SEO 메타데이터 누락: 페이지 단위 메타데이터 처리가 없습니다.
퇴사 처리 로직을 별도 widget/feature로 분리하고, 페이지는 해당 컴포넌트를 조합만 하도록 리팩토링을 권장합니다.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/manager/home/index.tsx` around lines 27 - 327, Extract the resignation handling business logic from the ManagerHomePage function into a separate widget or feature component. Move the resignTargetWorkerId and isResignErrorOpen state variables, the useResignWorkerMutation hook call, and the two ConfirmModal components (the resignation confirmation modal and the error modal) into a dedicated ResignWorkerModal or similar component that you create in the widgets or features layer. Have ManagerHomePage only import and compose this new component, keeping the page layer focused on composition rather than business logic. Additionally, apply React.lazy and Suspense for page-level code splitting and add SEO metadata handling to the page component to fully comply with the pages layer guidelines.Source: Coding guidelines
93-93:⚠️ Potential issue | 🟠 Major | ⚡ Quick winaria-label이 버튼의 실제 동작과 불일치합니다.
버튼은 업장 변경 모달을 여는데 aria-label은 "배너 상세 보기"로 되어 있습니다. 스크린 리더 사용자에게 잘못된 정보를 전달합니다.
[accessibility]
♻️ 제안 수정
<button type="button" - aria-label="배너 상세 보기" + aria-label="업장 변경" className="absolute bottom-[40px] right-[20px] h-[26px] w-[26px]" onClick={openWorkspaceChangeModal} >🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/manager/home/index.tsx` at line 93, The aria-label attribute on the button does not accurately describe its actual function. The aria-label currently says "배너 상세 보기" (View banner details), but the button actually opens a store/location change modal. Update the aria-label value to correctly reflect the button's actual action, such as "업장 변경" or "업장 변경 모달 열기", so that screen reader users receive accurate information about what the button does.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/pages/manager/home/index.tsx`:
- Around line 27-327: Extract the resignation handling business logic from the
ManagerHomePage function into a separate widget or feature component. Move the
resignTargetWorkerId and isResignErrorOpen state variables, the
useResignWorkerMutation hook call, and the two ConfirmModal components (the
resignation confirmation modal and the error modal) into a dedicated
ResignWorkerModal or similar component that you create in the widgets or
features layer. Have ManagerHomePage only import and compose this new component,
keeping the page layer focused on composition rather than business logic.
Additionally, apply React.lazy and Suspense for page-level code splitting and
add SEO metadata handling to the page component to fully comply with the pages
layer guidelines.
- Line 93: The aria-label attribute on the button does not accurately describe
its actual function. The aria-label currently says "배너 상세 보기" (View banner
details), but the button actually opens a store/location change modal. Update
the aria-label value to correctly reflect the button's actual action, such as
"업장 변경" or "업장 변경 모달 열기", so that screen reader users receive accurate
information about what the button does.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a5be5930-2f8a-4f3e-8eab-19fe8bb57472
⛔ Files ignored due to path filters (1)
src/assets/icons/home/manager-home-banner-list.svgis excluded by!**/*.svg
📒 Files selected for processing (1)
src/pages/manager/home/index.tsx
dohy-eon
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ID
변경 내용
구현 사항
구현 시연 (필요 시)
Summary by CodeRabbit