fix: MBCondaPackages version string doubled when include_channels=True#28
Merged
fix: MBCondaPackages version string doubled when include_channels=True#28
Conversation
alubbock
force-pushed
the
fix/conda-version-concat
branch
from
4f2cfa7 to
8acafeb
Compare
alubbock
force-pushed
the
fix/conda-version-concat
branch
from
7a73407 to
e894603
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg_version += pkg_version + '(' + pkg_data[3] + ')'doubled the version string, producing e.g.1.24.3py311ha0bc626_01.24.3py311ha0bc626_0(conda-forge)instead of1.24.3py311ha0bc626_0(conda-forge)pkg_version += '(' + pkg_data[3] + ')'microbench/tests/test_conda.pywith mocked subprocess to verify correct parsing with and without channels/build strings