fix: inverted set difference in MBNvidiaSmi attribute validation#29
Merged
fix: inverted set difference in MBNvidiaSmi attribute validation#29
Conversation
…lagging known attrs as unknown)
alubbock
force-pushed
the
fix/nvidia-attr-validation
branch
from
cc2e6cf to
4f8269f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set(_available).difference(user_attrs)was backwards: it flagged default attributes not present in the user's list as "unknown", rather than flagging user-specified attributes that don't existset(user_attrs).difference(_available)so the error message "Unknown nvidia_attributes" is semantically correct