Skip to content

fix: wrong parameter name in test_multi_iterations; clarify timezone docs#30

Merged
alubbock merged 3 commits intomainfrom
fix/test-tz-param
Mar 12, 2026
Merged

fix: wrong parameter name in test_multi_iterations; clarify timezone docs#30
alubbock merged 3 commits intomainfrom
fix/test-tz-param

Conversation

@alubbock
Copy link
Copy Markdown
Owner

Summary

  • test_multi_iterations passed timezone= to MicroBench.__init__, but the parameter is tz=. The timezone was silently stored as a static metadata field instead of being applied, so timestamps remained in UTC. The test then checked results['timezone'] (the static field) rather than results['timestamp_tz'] (the actual timezone label).
  • Fixed to use tz= and assert against results['timestamp_tz']
  • Expanded the Timezones section of the README to clarify that timestamp_tz records the timezone for reference, and shows how to use the local machine's timezone

@alubbock alubbock merged commit 5b343ce into main Mar 12, 2026
19 checks passed
@alubbock alubbock deleted the fix/test-tz-param branch March 12, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant