fix: MBFunctionCall stored JSON strings instead of raw values (double-encoding)#34
Merged
fix: MBFunctionCall stored JSON strings instead of raw values (double-encoding)#34
Conversation
…trings (prevented double-encoding)
a60167d to
0005314
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capture_function_args_and_kwargscalledself.to_json(v)and stored the resulting JSON string inbm_data['args']/bm_data['kwargs']. Whenoutput_resultlater serialisedbm_data, these strings were serialised again, turning e.g.{'k': 1}into the escaped string"{\"k\": 1}"in the output.self.to_json(v)only as an encodability check, then store the raw valuev— matching howMBReturnValuehandles return valuestest_functioncall_args_not_double_encodedto verify args/kwargs round-trip as their native Python types