fix: LiveStream tail loop ran forever with no way to stop it#36
Merged
fix: LiveStream tail loop ran forever with no way to stop it#36
Conversation
62d924c to
5eb2ca9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LiveStream.__init__ran the file-tailing loop inline, blocking forever. Because the constructor never returned,stop()was unreachable from outside — making it useless.__init__returns immediately with a usable objectstop()to signal termination andjoin()to wait for the thread to finishtime.sleep()withthreading.Event.wait()sostop()responds promptly rather than waiting out a full sleep intervalmicrobench/tests/test_livestream.pywith two tests covering normal processing andstop()termination