feat: implement get_results() for MicroBenchRedis#45
Merged
Conversation
Previously MicroBenchRedis inherited get_results() from MicroBench, which read from a StringIO that was never written to. Now it reads results back from the Redis list and returns a pandas DataFrame, consistent with the base class behavior. Updated README to show the simpler get_results() usage instead of the manual redis client approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MicroBenchRedis.get_results()now reads results back from the Redis list and returns a pandas DataFrame, matching the base class APIget_results()which read from a StringIO that was never written to, silently returning an empty DataFrameget_results()usage instead of the manual redis client approachTest plan
test_redis_get_results— verifies basic roundtrip (write + read back)test_redis_get_results_without_pandas— verifies ImportError when pandas unavailabletest_redis_multiple_results— verifies multiple benchmark runs are all returned