fix: capture both logical and physical CPU core counts#49
Merged
Conversation
psutil.cpu_count(logical=True) can return None on some platforms (e.g. macOS with psutil 7.x). Now captures both logical and physical counts so at least one is always available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
psutil.cpu_count(logical=True)returnsNoneon some platforms (e.g. macOS with psutil 7.x)cpu_cores_logicalandcpu_cores_physicalso at least one is always availableTest plan
test_psutilnow passes on macOS with psutil 7.x (was failing before)test_psutil_missing_raisesunchanged and passing