feat(docker): init docker images workflow#4
Merged
Conversation
titouanj
requested changes
Mar 19, 2025
ahuret
force-pushed
the
main
branch
4 times, most recently
from
bb8e7ff to
8493c0f
Compare
titouanj
requested changes
Mar 20, 2025
titouanj
reviewed
Mar 21, 2025
Contributor
titouanj
left a comment
titouanj
left a comment
There was a problem hiding this comment.
You need to rebase your banch
And I don't know if the author LABEL should be you or not
Contributor
Author
|
@titouanj done for the rebase ! And yes we talked a bit about the author thing with @TheElectronWill and I think we decided this, but we could instead use another one. |
Member
|
After reading some doc I think that the best would be to have a specific alumet email that redirects to our emails. So we can something like |
Contributor
Author
|
Finally made the change to |
titouanj
previously approved these changes
Mar 21, 2025
TheElectronWill
requested changes
Mar 24, 2025
TheElectronWill
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding github workflow to build docker images.
This PR covers 5 docker images:
Redhat UBI's images have been optimized to have minimum size (69MB that could maybe be optimized to 49MB with tricks) and sounds as good production images. The 9.5 version is also tagged as the latest image in the registry.
Others are > 100 MB and comes with package manager which make them more convenient for debug purpose.
The PR doesn't cover ARCH and only cover x86_64 (amd64) even if it gets an input variable "target-architecture". This will come in another PR later.
A job of tests is also added in the workflow and use dgoss (goss for docker) and use same validation YAML values as RPM and Debian workflows without package and systemd unit concerns.
The docker repository comes with a README.md file that aims to help user to use docker image with RAPL plugin and could be extended for other use cases specific to docker images.