Skip to content

Undo issue monitor sync guard#141

Merged
alvarosanchez merged 2 commits into
mainfrom
codex/undo-issue-monitor-abstention
May 25, 2026
Merged

Undo issue monitor sync guard#141
alvarosanchez merged 2 commits into
mainfrom
codex/undo-issue-monitor-abstention

Conversation

@alvarosanchez
Copy link
Copy Markdown
Owner

Summary

  • Undo the issue-monitor abstention behavior introduced for PR Respect active Paperclip issue monitors #130.
  • Let GitHub Sync reconcile PR-linked Paperclip issue status from live GitHub state even when Paperclip execution state still contains scheduled monitor metadata.
  • Remove the README/SPEC contract that said scheduled monitors own those waits, and flip the regression test to assert sync reconciliation happens.

Why

Agents are now instructed not to create Paperclip issue monitors for waits that GitHub Sync already handles. Keeping the plugin-side monitor guard means stale or scheduled monitor metadata can prevent GitHub Sync from moving issues back to actionable states when GitHub CI, mergeability, or review state changes.

Validation

  • pnpm exec tsx --test --test-name-pattern "scheduled-monitor issue" tests/plugin.spec.ts failed before the worker rollback and passed after it.
  • pnpm typecheck
  • pnpm test
  • pnpm build
  • git diff --check

Model Used

  • Model ID/version: GPT-5 Codex via the Codex desktop app
  • Context window: not exposed by the runtime in this session
  • Capabilities used: code editing, shell commands, GitHub CLI, local test/build verification

Copilot AI review requested due to automatic review settings May 25, 2026 15:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR rolls back the “scheduled Paperclip issue monitor abstention” behavior (introduced in PR #130) so GitHub Sync can once again reconcile Paperclip issue status/assignee/execution-state from live GitHub state even when the Paperclip issue still contains scheduled monitor metadata.

Changes:

  • Removed the scheduled-monitor guardrails in the worker so sync can apply status reconciliation (including PR-linked issues and transferred-issue cancellation) regardless of scheduled monitor metadata.
  • Simplified execution-state normalization/types by removing monitor state parsing from the worker.
  • Updated regression tests and removed the README/SPEC contract language that described monitor-owned abstention.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/plugin.spec.ts Updates regression expectations to assert sync reconciliation occurs for scheduled-monitor issues.
src/worker.ts Removes scheduled-monitor abstention logic and monitor-state normalization/types so sync proceeds with reconciliation.
SPEC.md Removes the spec contract requiring abstention while a scheduled monitor exists.
README.md Removes the documented “scheduled monitor owns the wait” behavior from the behavior list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/plugin.spec.ts
@alvarosanchez alvarosanchez merged commit 139892a into main May 25, 2026
1 check passed
@alvarosanchez alvarosanchez deleted the codex/undo-issue-monitor-abstention branch May 25, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants