fix: resolve clippy warnings breaking CI on main#46
Merged
Conversation
- Replace single-arm match with if-let for modulo-by-zero check (clippy::single_match) - Remove redundant closure in join() (clippy::redundant_closure) - Replace 3.14 test values with 2.72 to avoid clippy::approx_constant (PI detection) Fixes CI failure introduced by #45.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on main is failing after #45 merge due to 3 clippy warnings treated as errors:
clippy::single_match— single-arm match for modulo-by-zero check ineval.rsclippy::redundant_closure— unnecessary closure injoin()infunctions.rsclippy::approx_constant— test values3.14detected as approximate PI infunctions.rsFix
matchwithif letfor the modulo-by-zero check|v| to_str(v)withto_strdirectly3.14to2.72to avoid PI detectionAll 575 tests passing, clippy clean.