fix(Bank Reconciliation Beta): use bt.date to determine sconto validity#357
Merged
barredterra merged 2 commits intoversion-15-hotfixfrom Mar 27, 2026
Merged
fix(Bank Reconciliation Beta): use bt.date to determine sconto validity#357barredterra merged 2 commits intoversion-15-hotfixfrom
barredterra merged 2 commits intoversion-15-hotfixfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
barredterra
approved these changes
Mar 27, 2026
Member
|
🎉 This PR is included in version 15.33.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
get_payment_entryin ERPNext uses thereference_dateto determine, if a potential sconto payment is on time.Problem
We didn't pass the Bank Transaction's Date. Therefore,
get_payment_entryused today's date as `reference_date``-> OUTCOME: Discounts were not considered in some cases.