llama-memory: enable checkpointing with partial rollback#15
Merged
Conversation
ggerganov
reviewed
May 15, 2026
| } | ||
| } | ||
|
|
||
| const uint32_t cell_id = rs_idx_cur * size + (cell.src >= 0 ? cell.src : (int32_t) i); |
There was a problem hiding this comment.
cell.src >= 0 ? cell.src
I guess this was the part that I was missing in my approach. I will take detailed look tomorrow and run some tests to verify it's working as expected.
|
Tested on Qwen3.6-27B. Checkpoint miss from ggml-org#22673 (in master and mtp-clean) is fixed here. nice work!.👍 11.26.676.492 I slot launch_slot_: id 0 | task 4631 | processing task, is_child = 0
11.26.676.549 W slot update_slots: id 0 | task 4631 | n_past = 101412, slot.prompt.tokens.size() = 101743, seq_id = 0, pos_min = 101742, n_swa = 0
11.26.676.549 I slot update_slots: id 0 | task 4631 | Checking checkpoint with [101409, 101409] against 101412...
11.26.731.828 W slot update_slots: id 0 | task 4631 | restored context checkpoint (pos_min = 101409, pos_max = 101409, n_tokens = 101410, n_past = 101410, size = 262.973 MiB)
11.27.422.622 W slot create_check: id 0 | task 4631 | erasing old context checkpoint (pos_min = 94538, pos_max = 94538, n_tokens = 94539, size = 255.293 MiB)
11.27.533.495 I slot create_check: id 0 | task 4631 | created context checkpoint 24 of 24 (pos_min = 101752, pos_max = 101752, n_tokens = 101753, size = 263.356 MiB) |
ggerganov
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.