Update request to handle both JSON-valid string and JSON encoded dict#121
Merged
tsolakoua merged 2 commits intoamadeus4dev:masterfrom Oct 28, 2021
Merged
Update request to handle both JSON-valid string and JSON encoded dict#121tsolakoua merged 2 commits intoamadeus4dev:masterfrom
tsolakoua merged 2 commits intoamadeus4dev:masterfrom
Conversation
tsolakoua
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
__build_http_requestinrequest.pyto support both JSON objects and JSON valid strings.Changes for this pull request
This PR is intended to close #51
Checklist
🟢 Code passes linting and tests.
Comments
The draft solution discussed in #51 is implemented as it seems a reasonable fix.