Skip to content

Conversation

@samheyman
Copy link
Contributor

Fixes #

Changes for this pull request

Checklist

Remove this if you have done all of these:

  • Ensure all tests pass and linting
  • Add any changes to the README
  • Add any changes or new comments to SDK methods
  • Ensure this PR only changes what it is intended to change

@cbetta
Copy link
Contributor

cbetta commented Apr 8, 2018

@samheyman why are we adding all of this into one PR? Also, if we're renaming to a singular air-traffic, why not also make the change to the /travelled` bit?

@cbetta cbetta changed the title typo in README Change README and Fix Air Traffics path Apr 8, 2018
@samheyman
Copy link
Contributor Author

Short answer: I can't handle pull requests correctly (I opened a PR and then each following push was added to it)
Air-traffic was a change request here so updated that. Will look at travelled now.

@samheyman samheyman merged commit a7db7ff into amadeus4dev:master Apr 9, 2018
@samheyman
Copy link
Contributor Author

@cbetta what's the issue with the /travelled part you mentioned?

@cbetta
Copy link
Contributor

cbetta commented Apr 9, 2018

I thought that wasn't the URL anymore. Didn't it change to /v1/travel/analytics/air-traffic/travelled and /v1/travel/analytics/air-traffic/booked?

tsolakoua pushed a commit that referenced this pull request Jan 10, 2020
Change README and Fix Air Traffics path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants