Fix interface godoc: replace sql.ErrNoRows with ErrNotFound in store contracts#26
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/amalgamated-tools/goauth/sessions/67eff491-9050-452c-89d5-1d912e5c585f Co-authored-by: veverkap <22348+veverkap@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
veverkap
April 17, 2026 17:12
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates store interface Godoc to consistently document ErrNotFound (the package sentinel error) as the “not found” contract instead of sql.ErrNoRows, aligning implementor expectations with the package’s stated error semantics.
Changes:
- Updated
SessionStoremethod comments to referenceErrNotFoundfor not-found behavior. - Updated
EmailVerificationStore.ConsumeEmailVerificationcomment to referenceErrNotFound.
Show a summary per file
| File | Description |
|---|---|
| auth/types.go | Aligns interface method documentation with the package-level ErrNotFound sentinel contract (avoids sql.ErrNoRows in store contracts). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SessionStoreandEmailVerificationStoreinterface method comments referencedsql.ErrNoRowsas the not-found return value, directly contradicting the package's ownErrNotFoundsentinel contract defined just above them. This mismatch was the root cause of implementors returning the wrong error.Changes
auth/types.go: Updated four method comments to referenceErrNotFoundinstead ofsql.ErrNoRows:SessionStore.FindSessionByIDSessionStore.FindSessionByRefreshTokenHashSessionStore.DeleteSessionEmailVerificationStore.ConsumeEmailVerification