Conversation
|
🧩 Build Artifacts ✅ The following build artifacts were produced: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the logging system by removing the compile-time definition LCM_LOG_DEFAULT_ENABLED and defaulting logging to disabled. Logging is now explicitly enabled in the connmanctl example and via a new logging_init.cpp helper for specific tests. The review feedback highlights that some test targets might now lack logging due to the removal of the global definition and suggests using the [[maybe_unused]] attribute on the static initializer in logging_init.cpp to avoid potential compiler warnings.
Remove the use of the LCM_LOG_DEFAULT_ENABLED compile definition. LCM_LOG has to be enable always at runtime. Enable LCM_LOG at runtime for the tests and the example. This solves #24. Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
|
🧩 Build Artifacts ✅ The following build artifacts were produced: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the use of the LCM_LOG_DEFAULT_ENABLED compile definition. LCM_LOG has to be enable always at runtime.
Enable LCM_LOG at runtime for the tests and the example. This solves #24.