Skip to content

v1.33.1 — Robust self-detection (QNAP / non-resolvable HOSTNAME)

Choose a tag to compare

@amayer1983 amayer1983 released this 28 Jun 13:55
· 2 commits to main since this release

Fixed

  • Self-detection failed where \$HOSTNAME isn't an inspect-resolvable reference (#41, @NotRetarded). On some hosts — confirmed on QNAP Container Station — \$HOSTNAME is an ID-looking string that docker inspect reports as no such object. Every self-detection path resolved the running container by inspecting \$HOSTNAME directly, so all silently failed: Docksentry checked (and could try to update) itself via the regular flow instead of filtering itself out, and the self-update paths couldn't identify their own container (so AUTO_SELFUPDATE never actually self-updated).

    Self-resolution is now centralised in UpdateChecker.resolve_own_id() / inspect_self(): it inspects by \$HOSTNAME//etc/hostname first (the normal fast path, unchanged on standard Docker) and, when that fails, falls back to scanning running containers for one whose Config.Hostname matches \$HOSTNAME. All four call sites route through it (self-filter, auto-self-update, manual /selfupdate, /check badge).

Full 16-script regression sweep green.