Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes “groups” via the authenticated API and extends instance provisioning/listing to support group-based workflows (workspace creation, filtering, and reassignment).
Changes:
- Add
GET /api/groupsandPOST /api/groupsendpoints for listing/creating groups. - Extend
GET /api/instancesto support filtering bygroup_id/group_slugand include group details in responses. - Add
PATCH /api/instance/{uuid}/groupfor reassigning an instance to a group, plus feature tests for the new behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
app/Http/Controllers/Api/AuthenticatedApiController.php |
Implements group endpoints, adds group-aware instance filtering/formatting, and adds instance-to-group reassignment + group resolution helper. |
routes/api.php |
Registers the new group and reassignment routes under existing Sanctum ability middleware. |
tests/Feature/Api/AuthenticatedApiTest.php |
Adds coverage for groups endpoints and new instance/group flows (filtering, provisioning, reassignment). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/amazeeio/polydock-engine/sessions/e9967acf-31ef-46fa-8038-0bbfbe99ef7f Co-authored-by: dan2k3k4 <158704+dan2k3k4@users.noreply.github.com>
Agent-Logs-Url: https://github.com/amazeeio/polydock-engine/sessions/c8699b49-2d9d-48d5-bdc1-1ce7861e7e7a Co-authored-by: dan2k3k4 <158704+dan2k3k4@users.noreply.github.com>
Agent-Logs-Url: https://github.com/amazeeio/polydock-engine/sessions/c8699b49-2d9d-48d5-bdc1-1ce7861e7e7a Co-authored-by: dan2k3k4 <158704+dan2k3k4@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.