Skip to content
This repository was archived by the owner on Mar 31, 2021. It is now read-only.

Conversation

@tbrugz
Copy link
Contributor

@tbrugz tbrugz commented May 29, 2019

Issue #, if available: #11

Description of changes:

Changes constructor of DatabaseMetaDataImpl.ColumnMetadataStatement to allow null on columnNamePattern parameter

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@arsen-es
Copy link
Contributor

Thank you for the change. Could you please also include a test which covers the null argument code path?

@tbrugz
Copy link
Contributor Author

tbrugz commented Jun 24, 2019

added tests for null and not null columnNamePattern argument

@dai-chen dai-chen requested review from arsen-es and dai-chen June 24, 2019 20:11
Copy link
Contributor

@arsen-es arsen-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@arsen-es arsen-es merged commit 2a3ac84 into amazon-archives:master Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants