Fix release-build panic in resolve_color_choice#220
Merged
Conversation
almann
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
When testing Ion CLI before publishing the 0.12.0 release, I discovered a bug. It turns out that a function I had been using as a guard to prevent panics is actually a no-op when you do a release build, so all my previous testing had missed it.
Clap's
try_contains_idrelies onverify_argwhich is gated behind#[cfg(debug_assertions)], so it always returnsOk(())in release builds. Commands that don't register--color/--no-color(e.g.,inspect) would pass the guard, thenget_flag("color")would panic because the arg was never configured withArgAction::SetTrue.The fix uses
try_get_one::<bool>with pattern matching. ForSetTrueargs, clap stores a default value, soOk(Some(&false))means "registered but not passed" whileOk(None)(release) orErr(debug) means "never registered." The wildcard arm returnsColorChoice::Never, preserving the original semantics.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.