Add Windows build again, remove LLVM, Clang CI setup#27
Merged
popematt merged 2 commits intoamazon-ion:masterfrom Jun 9, 2022
camerondurham:camdurha-test-ci
Merged
Add Windows build again, remove LLVM, Clang CI setup#27popematt merged 2 commits intoamazon-ion:masterfrom camerondurham:camdurha-test-ci
popematt merged 2 commits intoamazon-ion:masterfrom
camerondurham:camdurha-test-ci
Conversation
* remove llvm and clang related deps setup on Windows * enable parallel tests, run rustfmt
popematt
approved these changes
Jun 9, 2022
Contributor
popematt
left a comment
popematt
left a comment
There was a problem hiding this comment.
Thanks for this contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Another very minor CI change after seeing the
ion-cdependency was removed (:tada:). Wanted address some of the old TODOs mentioned in previous PR.Had originally added
-- --test-threads=1since tests were flakey when there was theion-cdependency. Running locally and in CI showed this is no longer needed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.