Merged
Conversation
zslayton
approved these changes
Oct 17, 2022
Contributor
zslayton
left a comment
There was a problem hiding this comment.
Thanks! Side question: do we have a unit test somewhere that guarantees that text values written by the lines writer always escape their return lines?
Contributor
Author
No... I didn't think of this, so I have not looked into it. |
Contributor
Offhand, I don't think any of the text writers emit multiline strings yet, so we're probably ok for now. |
f376714 to
dbbf3b1
Compare
Also adopt ion-rs 0.14.0
dbbf3b1 to
c5f25ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adopt ion-rs 0.14.0
Description of changes:
This adds support for the new
lines()formatter inion-rs: https://github.com/amzn/ion-rust/blob/main/src/text/raw_text_writer.rs#L34-L52This is helpful for working with line-delimited text-oriented tooling (
sort,grep,uniqetc.).Testing:
Comparing the various text formats.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.