Skip to content

Updates ion-c to latest.#4

Merged
almann merged 1 commit intomasterfrom
ionc-update
Jul 29, 2020
Merged

Updates ion-c to latest.#4
almann merged 1 commit intomasterfrom
ionc-update

Conversation

@almann
Copy link
Copy Markdown
Contributor

@almann almann commented Jul 29, 2020

  • Updates build.rs:
    • Changes decNumberStatic to decNumber_static because of changes
      to upstream.
    • Links against libc++ on macOS and libstdc++ on Linux.
    • Makes C++ linkage explicitly dynamic.
    • Adds TODO/explicit build failure for Windows and other platform.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Updates `build.rs`:
  - Changes `decNumberStatic` to `decNumber_static` because of changes
    to upstream.
  - Links against `libc++` on macOS and `libstdc++` on Linux.
  - Makes C++ linkage explicitly dynamic.
  - Adds TODO/explicit build failure for Windows and other platform.
@almann almann requested review from tgregg and zslayton July 29, 2020 16:51
Copy link
Copy Markdown
Contributor

@zslayton zslayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@almann almann merged commit e8d0d0a into master Jul 29, 2020
@almann almann deleted the ionc-update branch July 29, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants