Conversation
* Created a beta command called `inspect` that writes a given binary Ion stream to the console alongside its equivalent text Ion. It prints the offset and length of each value, as well as any symbol IDs used to encode that value's components. * All commands return an anyhow::Result to simplify bubbling errors up to the user level. * Created aliases for cumbersome types related to clap configuration. * `beta` module is now a directory.
cheqianh
approved these changes
Jan 21, 2021
Contributor
cheqianh
left a comment
cheqianh
left a comment
There was a problem hiding this comment.
Played around, that's so cool 😎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds a beta command called
inspectthat writes a given binary Ion stream to the console alongside its equivalenttext Ion. It prints the offset and length of each value, as well as any symbol IDs used to encode that value's components.
Help
Example
Other changes:
anyhow::Resultto simplify bubbling errors up to the user level.CommandRunner,CommandConfig) for cumbersome types related to clap configuration.betamodule is now a directory.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.