Adding missed changes for empty symbol support#109
Merged
Conversation
One is an ignored for malformed symbols, "" is valid so should not be there Another is part of the writter. Since it was not caught by any UT it could be dead code. Will investigate marking it as deprecated and potentially removing as a separate task #42
Contributor
Author
|
The test actually passes, will submit a separate PR removing the ignore referencing #44 |
tgregg
pushed a commit
that referenced
this pull request
Jun 21, 2018
One is an ignored for malformed symbols, "" is valid so should not be there Another is part of the writer. Since it was not caught by any UT it could be dead code. Will investigate marking it as deprecated and potentially removing as a separate task #42
tgregg
pushed a commit
that referenced
this pull request
Jun 21, 2018
…symbol support (#109)' from branch 'master' into mainline"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One is an ignored for malformed symbols, "" is valid so should not be
there
Another is part of the writer. Since it was not caught by any UT it
could be dead code, will investigate marking it as deprecated and
potentially removing as a separate task
#42