Rejects duplicate symbol/import fields in the symbol table declaration#119
Merged
Rejects duplicate symbol/import fields in the symbol table declaration#119
Conversation
added 4 commits
August 9, 2017 11:33
tgregg
reviewed
Aug 14, 2017
Contributor
tgregg
left a comment
tgregg
left a comment
There was a problem hiding this comment.
Looks good -- staying tuned for the added ion-tests coverage.
| // As per the Spec, other field types are treated as | ||
| // empty lists | ||
| if(foundLocalSymbolList){ | ||
| throw new IonException("Multiple symbol tables found."); |
Contributor
There was a problem hiding this comment.
"Multiple symbols fields found within a single local symbol table."
| case IMPORTS_SID: | ||
| { | ||
| if(foundImportList){ | ||
| throw new IonException("Multiple import tables found."); |
Contributor
There was a problem hiding this comment.
"Multiple imports fields found within a single local symbol table."
tgregg
approved these changes
Sep 6, 2017
toddjonker
reviewed
Oct 14, 2017
| // empty lists | ||
| if(foundLocalSymbolList){ | ||
| throw new IonException("Multiple symbol tables found."); | ||
| throw new IonException("Multiple symbol fields found within a single local symbol table."); |
Contributor
There was a problem hiding this comment.
These error messages really need to include location information. Humans are going to want to debug this stuff, and we need to provide them with all relevant context at hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#35