Merged
Conversation
tgregg
reviewed
Sep 6, 2017
| final void setFieldNameSymbol(SymbolToken name) | ||
| { | ||
| assert(this.getContainer() == null); | ||
| //assert(this.getContainer() == null); |
| public final SymbolToken getKnownFieldNameSymbol() | ||
| { | ||
| SymbolToken token = this.getFieldNameSymbol(); | ||
| if(this.getFieldName() == null && token.getSid() != 0) { |
Contributor
There was a problem hiding this comment.
Instead of this.getFieldName(), why isn't this just token.getName()?
| IonValueLite copy = child.clone(childContext); | ||
| if (isStruct) copy.setFieldName(child.getFieldName()); | ||
| if (isStruct) { | ||
| copy.setFieldNameSymbol(child.getKnownFieldNameSymbol()); |
Contributor
There was a problem hiding this comment.
This is indented with 8 spaces, should be 4 to match the rest of the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-changed functionality that assumed that fieldID is a unique identifier for a symbolID
-removed testHugeWrite due to travis memory restrictions.
-added support for sid0 in ID lookup logic.