Skip to content

Handling CE to BCE dates during add* operations#131

Merged
raganhan merged 1 commit intomasterfrom
i130-timestamp-bce-bug
Nov 20, 2017
Merged

Handling CE to BCE dates during add* operations#131
raganhan merged 1 commit intomasterfrom
i130-timestamp-bce-bug

Conversation

@raganhan
Copy link
Copy Markdown
Contributor

Checking if the ERA flips in any Timestamp.add* operation and throwing
an error if that's the case

ref: #130

Checking if the ERA flips in any Timestamp.add* operation and throwing
an error if that's the case
@raganhan raganhan requested review from tgregg and therapon November 15, 2017 01:18
Copy link
Copy Markdown
Contributor

@therapon therapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raganhan raganhan merged commit ecd7918 into master Nov 20, 2017
@raganhan raganhan deleted the i130-timestamp-bce-bug branch February 3, 2018 01:33
tgregg pushed a commit that referenced this pull request Jun 21, 2018
Checking if the ERA flips in any Timestamp.add* operation and throwing
an error if that's the case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants