Skip to content

Fix release artifact upload workflow#490

Merged
popematt merged 1 commit intoamazon-ion:masterfrom
popematt:gha-fix
May 31, 2023
Merged

Fix release artifact upload workflow#490
popematt merged 1 commit intoamazon-ion:masterfrom
popematt:gha-fix

Conversation

@popematt
Copy link
Copy Markdown
Contributor

Issue #, if available:

None.

Description of changes:

The workflow failed to upload the BOM and JAR for the last release. This should fix the permissions issue that caused the failure. Unfortunately, I don't think it's possible to test it without creating a release.

Incidental changes include:

  • updating the configuration for the cyclonedxBom task (add a depends-on relationship and remove some redundant config)
  • fixing some typos in build and workflow files

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@popematt popematt requested a review from jobarr-amzn May 31, 2023 03:58
@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b30a15c) 66.83% compared to head (d712b79) 66.84%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #490   +/-   ##
=========================================
  Coverage     66.83%   66.84%           
- Complexity     5420     5421    +1     
=========================================
  Files           156      156           
  Lines         22728    22728           
  Branches       4087     4087           
=========================================
+ Hits          15191    15192    +1     
  Misses         6241     6241           
+ Partials       1296     1295    -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@popematt popematt requested review from cheqianh and removed request for jobarr-amzn May 31, 2023 18:55
@popematt popematt merged commit 21cc9c0 into amazon-ion:master May 31, 2023
@popematt popematt deleted the gha-fix branch May 31, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants