Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #501 +/- ##
============================================
- Coverage 66.83% 66.82% -0.01%
+ Complexity 5420 5419 -1
============================================
Files 156 156
Lines 22728 22728
Branches 4087 4087
============================================
- Hits 15191 15189 -2
- Misses 6241 6242 +1
- Partials 1296 1297 +1 ☔ View full report in Codecov by Sentry. |
desaikd
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
After moving to Gradle, the 'test' target began running all tests under the 'test' directory. Previously, the Maven build had been executing AllTests, which is a suite that points to all tests. Because Gradle now runs everything, that means it runs all tests and AllTests, meaning that everything is executed twice.
Removing the AllTests suite does not result in a drop in code coverage. When executed locally on my machine,
./gradlew testcompleted about 1 minute faster without it. In GitHub Actions, executing the tests after this change took 4 minutes 27 seconds. The last successful execution before this PR took 9 minutes 47 seconds.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.