Fix JDK 8 compatibility#530
Merged
popematt merged 1 commit intoamazon-ion:masterfrom Jul 18, 2023
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #530 +/- ##
=========================================
Coverage 66.81% 66.82%
+ Complexity 5394 5391 -3
=========================================
Files 156 156
Lines 22724 22734 +10
Branches 4082 4081 -1
=========================================
+ Hits 15184 15191 +7
- Misses 6243 6246 +3
Partials 1297 1297 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Note that the |
jobarr-amzn
approved these changes
Jul 18, 2023
| steps: | ||
| - name: Set up JDK 1.8 | ||
| uses: actions/setup-java@v1 | ||
| - name: Set up JDK 11 |
Contributor
There was a problem hiding this comment.
Is there any point in naming this with the version when that is redundant?
Contributor
Author
There was a problem hiding this comment.
You can easily read it from the GHA status page, I suppose. 🤷♂️
tgregg
approved these changes
Jul 18, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
Setting the target and source compatibility compiler options to JDK 8 is insufficient for ensuring JDK 8 compatibility of the JAR that we publish. We need to set the
releaseoption, which is not supported by JDK 8javac, so we're dropping support for building with JDK 8.See https://saker.build/blog/javac_source_target_parameters/index.html
This is a two way door. In theory, it is possible to add some conditional logic to the Gradle build script to only set this option when compiling with JDK 9 or higher, but I don't think we have a compelling reason for doing that right now.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.