Refactor ion-java-cli to standard layout

[gliptak]

Issue #, if available: fix (partial) #66

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (b9e5fe6) 66.88% compared to head (d630c5b) 66.88%.

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #545   +/-   ##
=========================================
  Coverage     66.88%   66.88%           
+ Complexity     5412     5411    -1     
=========================================
  Files           156      156           
  Lines         22769    22769           
  Branches       4095     4095           
=========================================
+ Hits          15228    15230    +2     
+ Misses         6246     6243    -3     
- Partials       1295     1296    +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gliptak]

@jobarr-amzn please review

[popematt]

I took a look at this. You're right that the current project layout does not follow the Gradle convention. However, the downside of relocating these files is that it becomes harder to trace their history in GitHub.

Is there any particular reason you want to make this change, aside from it being more conventional?

[gliptak]

yes, following convention (and improving tooling friendliness)

as for diff, git offers support https://stackoverflow.com/q/5730460

[popematt]

git offers support

Yes, I am aware of that. I was actually more interested in whether GitHub would correctly show the "blame" on moved/renamed files—it's a helpful tool sometimes to find out when and why a particular bit of code was introduced (and changed over time). That being said, I went and tested it out on the PR branch just to be sure, and to my surprise, the blame is preserved. (I wonder when that started happening... or maybe I'm getting confused with a different git host.)

Anyway, with that out of the way, I see no reason not to accept this change.

[jobarr-amzn]

Apologies, @gliptak - I was wrapped up in some other work the past couple of weeks and this one slipped past me. Thanks for reviewing it, @popematt!