Skip to content

Fixes a bug in that prevented the correct IonContext from being copied via IonStruct.cloneAndRemove and IonStruct.cloneAndRetain. #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgregg merged 1 commit into from
Sep 15, 2023
Merged

Fixes a bug in that prevented the correct IonContext from being copied via IonStruct.cloneAndRemove and IonStruct.cloneAndRetain. #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/com/amazon/ion/impl/lite/IonStructLite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,7 @@ private IonStruct doClone(boolean keep, String... fieldNames)
// This ensures that we don't copy an unknown field name.
clonedChild._fieldName = value.getFieldName();
clonedChild._elementid(clone._child_count);
clonedChild._context = clone;
if (!clone._isSymbolIdPresent() && clonedChild._isSymbolIdPresent())
{
clone.cascadeSIDPresentToContextRoot();
Expand Down
9 changes: 9 additions & 0 deletions test/com/amazon/ion/StructTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,15 @@ public void testRemoveAfterClone()
assertNull(s2.get("b"));
}

@Test
public void testRemoveAfterCloneAndRemove() {
IonStruct struct1 = (IonStruct) system().singleValue("{a:1,b:2}");
IonStruct struct2 = struct1.cloneAndRemove("a");

assertNotNull(struct2.remove("b"));
assertFalse(struct2.containsKey("b"));
}

@Test
public void testPutOfClone()
{
Expand Down