Adds option to omit the Ion version marker from text output #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
approved these changes
Oct 17, 2019
tgregg
reviewed
Oct 17, 2019
| writer = blocking_writer(raw_writer, fp) | ||
| from_type = _FROM_TYPE_TUPLE_AS_SEXP if tuple_as_sexp else _FROM_TYPE | ||
| writer.send(ION_VERSION_MARKER_EVENT) # The IVM is emitted automatically in binary; it's optional in text. | ||
| if not binary and not omit_version_marker: |
Contributor
There was a problem hiding this comment.
Shouldn't this be if binary or not omit_version_marker:?
I mean, the tests pass so the current logic clearly works, but it looks weird to me. Are we relying on the fact that under the hood the binary writer always writes the ION_VERSION_MARKER_EVENT without being explicitly told to?
This was referenced Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #94
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.