Switch CI to GitHub actions#64
Merged
Merged
Conversation
added 4 commits
July 28, 2022 11:13
Define a GitHub Actions workflow to run tests in an AL2022 container.
keithaws
reviewed
Aug 1, 2022
| @@ -0,0 +1,3 @@ | |||
| FROM public.ecr.aws/debian/debian:11 | |||
|
|
|||
| RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get -y install --no-install-recommends build-essential debhelper git devscripts shellcheck | |||
Contributor
There was a problem hiding this comment.
The description of this change mentions shellcheck running in a Ubuntu container (shown below in .github/workflows/shellcheck.yml), but the package is also installed in the Debian container. Is this intentional?
Contributor
Author
There was a problem hiding this comment.
The .deb build process runs the test suite, which in this case involves running shellcheck, which is why it's there (and listed as a build-dependency in debian/control). I'd like to run the tests during rpm build as well, but shellcheck isn't in AL2022 yet.
Because of this, we run shellcheck twice, but having it as a discrete step is useful for visibility in the workflow runs.
keithaws
approved these changes
Aug 1, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #54
Description of changes:
Configure GitHub Actions on the main branch. Package builds are performed in Debian 11 and AL2022 container environments, and shellcheck is run in an Ubuntu worker. This fully replaces our previously configured CircleCI configuration, which no longer works since we don't have CircleCI active in this organization.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.