Doesn't depend on all database backends. #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works by having a wrapper that compiles the CLI on first use, when the database backend libraries were already downloaded by shards. Changes: - Rename src/micrate-bin.cr to src/micrate-cli.cr - Add src/micrate-wrapper.cr that compiles in a post install to bin/micrate. - bin/micrate compiles src/micrate-cli to bin/micrate-cli-<VERSION> - src/micrate-cli.cr only require database backends found in lib/ - Do not pin crystal-db version to avoid having to release new micrate versions on every crystal-db release. Fix amberframework#87
Contributor
Author
|
@crimson-knight could you review/provide some feedback on this? |
crimson-knight
approved these changes
Jun 21, 2025
Member
crimson-knight
left a comment
crimson-knight
left a comment
There was a problem hiding this comment.
I'm going to approve and merge this into master, and I'm building a new amber cli that'll depend on it and test against Windows, Linux and MacOS on github actions. If this finds a compatibility problem then I'll just make a PR with the solution.
Thank you for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works by having a wrapper that compiles the CLI on first use, when the database backend libraries were already downloaded by shards.
Changes:
Fix #87
Caution
Despite of the code dealing with windows I only tested this on Linux, would be nice if someone else test this (and possible fix it) on windows before merge.