docs: fix doc drift and update heading for MCP Server#2
Merged
jeremyeder merged 2 commits intomainfrom Mar 20, 2026
Merged
Conversation
Add `image` command to deploy.sh that builds and pushes to the OpenShift internal registry (with IMAGE_REGISTRY env var override for non-admin users who can't query the registry route). Add `IMAGE` support in `cmd_apply` to set the correct internal pull URL. Namespace creation uses `oc new-project` on OpenShift for proper RBAC. - Containerfile: set UV_CACHE_DIR and chmod g+rwX for OpenShift's restricted SCC (arbitrary UID) - Build with --platform=linux/amd64 and --provenance=false for cross-arch compat and registry compatibility - Remove imagePullSecrets via JSON patch in OpenShift overlay (internal registry uses default SA token) - Remove namespace.yaml from kustomize base (deploy.sh handles creation) - Rename all resources from mcp-server to gps-mcp-server - Rename namespace from gps to gps-mcp-server Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Update heading in README.md and CLAUDE.md to include "MCP Server" - Fix stale gps-mcp → gps-mcp-server references in DEPLOYMENT.md - Add docker build flags (--provenance=false --platform=linux/amd64) - Document image command and OpenShift internal registry workflow - Add IMAGE_REGISTRY and IMAGE env vars to Environment section Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (14)
Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting WalkthroughThis pull request rebrands the project to "GPS - Global Positioning System MCP Server," renames Kubernetes resources and deployments from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
jeremyeder
added a commit
that referenced
this pull request
Mar 23, 2026
* feat: deploy GPS to OpenShift via internal registry Add `image` command to deploy.sh that builds and pushes to the OpenShift internal registry (with IMAGE_REGISTRY env var override for non-admin users who can't query the registry route). Add `IMAGE` support in `cmd_apply` to set the correct internal pull URL. Namespace creation uses `oc new-project` on OpenShift for proper RBAC. - Containerfile: set UV_CACHE_DIR and chmod g+rwX for OpenShift's restricted SCC (arbitrary UID) - Build with --platform=linux/amd64 and --provenance=false for cross-arch compat and registry compatibility - Remove imagePullSecrets via JSON patch in OpenShift overlay (internal registry uses default SA token) - Remove namespace.yaml from kustomize base (deploy.sh handles creation) - Rename all resources from mcp-server to gps-mcp-server - Rename namespace from gps to gps-mcp-server Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs: fix stale references, add image/registry docs, update heading - Update heading in README.md and CLAUDE.md to include "MCP Server" - Fix stale gps-mcp → gps-mcp-server references in DEPLOYMENT.md - Add docker build flags (--provenance=false --platform=linux/amd64) - Document image command and OpenShift internal registry workflow - Add IMAGE_REGISTRY and IMAGE env vars to Environment section Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gps/gps-mcpreferences in DEPLOYMENT.md to usegps-mcp-serverimagecommand and OpenShift internal registry workflow in Deploy sectionIMAGE_REGISTRYandIMAGEenv vars to Environment sectionTest plan
grep -n 'gps[^-/\._"]' docs/DEPLOYMENT.mdreturns only legitimate references🤖 Generated with Claude Code