Skip to content

Remove --insecure-skip-tls-verify from CI oc login commands #1271

@ktdreyer

Description

@ktdreyer

Summary

All oc login commands in our GitHub Actions workflows use --insecure-skip-tls-verify, including production deploys. This disables TLS certificate validation and exposes CI to man-in-the-middle attacks.

Affected files

  • .github/workflows/components-build-deploy.yml — lines 209, 330, 363, 438 (staging/dev)
  • .github/workflows/prod-release-deploy.yaml — lines 348, 475 (production)

Proposed fix

Replace --insecure-skip-tls-verify with --certificate-authority=<path> referencing the cluster's CA bundle (injected as a GitHub Actions secret or checked into the repo if non-sensitive). If the clusters use publicly trusted certs, the flag can simply be removed.

Risk

Until fixed, a network-level attacker could intercept the oc login token exchange in CI and gain cluster access.

Metadata

Metadata

Assignees

No one assigned

    Labels

    ambient-code:auto-fixAmber agent: automated low-risk fixes (formatting, linting)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions