[Amber] Fix: Bug: Loading custom workflow from private GitHub repo downloads no files#1015
Merged
jeremyeder merged 3 commits intomainfrom Mar 25, 2026
Conversation
github-actions
bot
added
amber-generated
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| client := &http.Client{Timeout: 120 * time.Second} | ||
| resp, err := client.Do(httpReq) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in network request Critical
Contributor
Review Queue Status
Action needed: Fix failing CI checks: CodeQL
|
…epos The SelectWorkflow handler only updated the CRD but never called the runner's /workflow endpoint when the session was Running, so private repos could not be cloned at runtime. Additionally, the runner's /workflow endpoint did not accept auth token headers. - backend: SelectWorkflow now calls the runner's /workflow endpoint (same pattern as AddRepo) with X-GitHub-Token/X-GitLab-Token when the session is in Running phase - runner: change_workflow reads X-GitHub-Token/X-GitLab-Token headers and passes them to clone_workflow_at_runtime as overrides Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add isValidKubernetesName check on sessionName parameter before it reaches K8s API calls, addressing CodeQL uncontrolled-network-request finding. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jeremyeder
force-pushed
the
amber/issue-1014-bug-loading-custom-workflow-from-private-github-re
branch
from
066df46 to
2e6c924
Compare
jeremyeder
deleted the
amber/issue-1014-bug-loading-custom-workflow-from-private-github-re
branch
jeremyeder
added a commit
to jeremyeder/platform
that referenced
this pull request
Mar 26, 2026
…wnloads no files (ambient-code#1015) ## Automated Fix by Amber Agent This PR addresses issue ambient-code#1014 using the Amber background agent. ### Changes Summary - **Action Type:** auto-fix - **Commit:** c90c0f6 - **Triggered by:** Issue label/command ### Pre-merge Checklist - [ ] All linters pass - [ ] All tests pass - [ ] Changes follow project conventions (CLAUDE.md) - [ ] No scope creep beyond issue description ### Reviewer Notes This PR was automatically generated. Please review: 1. Code quality and adherence to standards 2. Test coverage for changes 3. No unintended side effects --- 🤖 Generated with [Amber Background Agent](https://github.com/ambient-code/platform/blob/main/docs/amber-automation.md) Closes ambient-code#1014 --------- Co-authored-by: Amber Agent <amber@ambient-code.ai> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Jeremy Eder <jeder@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Fix by Amber Agent
This PR addresses issue #1014 using the Amber background agent.
Changes Summary
Pre-merge Checklist
Reviewer Notes
This PR was automatically generated. Please review:
🤖 Generated with Amber Background Agent
Closes #1014