[Amber] Fix: Refresh token MCP tool silently swallows auth failures and reports success#1049
Merged
jeremyeder merged 1 commit intomainfrom Mar 26, 2026
Conversation
`_fetch_credential` was swallowing 401/403 responses and returning an empty dict, causing `populate_runtime_credentials` to always succeed and the MCP tool to report "Credentials refreshed successfully" even when the backend rejected authentication. Now `_fetch_credential` raises `PermissionError` on 401/403 when all token attempts are exhausted. `populate_runtime_credentials` collects these and re-raises so the tool correctly returns `isError: True` with the auth failure message. Fixes #1043 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
amber-generated
Contributor
|
lgtm |
jeremyeder
approved these changes
Mar 26, 2026
Contributor
jeremyeder
left a comment
jeremyeder
left a comment
There was a problem hiding this comment.
Code review: clean fix for issue #1043. The changes correctly propagate auth failures (401/403) as PermissionError instead of silently returning empty strings, surface the error message to the MCP tool response with isError=True, and aggregate auth failures across providers in populate_runtime_credentials. Tests are comprehensive. LGTM.
jeremyeder
deleted the
amber/issue-1043-refresh-token-mcp-tool-silently-swallows-auth-fail
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Fix by Amber Agent
This PR addresses issue #1043 using the Amber background agent.
Changes Summary
Pre-merge Checklist
Reviewer Notes
This PR was automatically generated. Please review:
🤖 Generated with Amber Background Agent
Closes #1043