Skip to content

feat(backend): filter disabled workflows from OOTB listing#1054

Merged
Gkrumbach07 merged 1 commit intoambient-code:mainfrom
jeremyeder:feat/workflow-enabled-filter
Mar 27, 2026
Merged

feat(backend): filter disabled workflows from OOTB listing#1054
Gkrumbach07 merged 1 commit intoambient-code:mainfrom
jeremyeder:feat/workflow-enabled-filter

Conversation

@jeremyeder
Copy link
Copy Markdown
Contributor

Summary

  • Workflows with "enabled": false in their .ambient/ambient.json are now completely excluded from the /api/workflows/ootb response
  • Previously all discovered workflows were returned with enabled: true regardless of their config
  • Field is optional — omitting it or setting "enabled": true preserves current behavior (backward compatible)

Test plan

  • Deploy backend, verify workflows without enabled field still appear
  • Set "enabled": false on a workflow's ambient.json, verify it no longer appears in API response or UI
  • Set "enabled": true explicitly, verify it still appears

🤖 Generated with Claude Code

Workflows with `"enabled": false` in their `.ambient/ambient.json`
are now completely excluded from the `/api/workflows/ootb` response.
Previously all discovered workflows were returned with `enabled: true`.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jeremyeder added a commit to ambient-code/workflows that referenced this pull request Mar 26, 2026
Set `"enabled": false` so this workflow is excluded from the
platform UI workflow picker. Requires ambient-code/platform#1054.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e53f1d12-228a-4c8e-b9f5-1a1ae0380e82

📥 Commits

Reviewing files that changed from the base of the PR and between 9ca8168 and c5251e1.

📒 Files selected for processing (1)
  • components/backend/handlers/sessions.go

Walkthrough

The ListOOTBWorkflows handler in the sessions module now supports an optional enabled field in the ambient workflow configuration. When the field is explicitly set to false, the workflow is excluded from the returned list; otherwise, the existing behavior is maintained.

Changes

Cohort / File(s) Summary
Ambient Workflow Configuration
components/backend/handlers/sessions.go
Added optional enabled field (*bool with omitempty) to ambient config parsing. Logic now checks if enabled is explicitly false and skips adding the workflow entry to the list when that condition is met.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(backend): filter disabled workflows from OOTB listing' accurately summarizes the main change: filtering out workflows marked as disabled from the OOTB workflow list.
Description check ✅ Passed The description directly relates to the changeset by explaining the new filtering behavior for disabled workflows, the backward compatibility of the optional field, and providing a clear test plan.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

jeremyeder added a commit to ambient-code/workflows that referenced this pull request Mar 26, 2026
* chore: disable prd-rfe-workflow from OOTB listing

Set `"enabled": false` so this workflow is excluded from the
platform UI workflow picker. Requires ambient-code/platform#1054.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* docs: document enabled, greeting, and rubric fields in schema

Adds documentation for optional ambient.json fields that were in use
but not documented in AMBIENT_JSON_SCHEMA.md.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ambient-code ambient-code bot added this to the Review Queue milestone Mar 27, 2026
@Gkrumbach07 Gkrumbach07 merged commit f73f1d2 into ambient-code:main Mar 27, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants