fix: change default model for new sessions to sonnet-4.6#1265
Merged
jeremyeder merged 5 commits intomainfrom Apr 9, 2026
Merged
fix: change default model for new sessions to sonnet-4.6#1265jeremyeder merged 5 commits intomainfrom
jeremyeder merged 5 commits intomainfrom
Conversation
Update the default model across all configuration layers: - models.json: defaultModel and anthropic providerDefault - CRD schema: spec.llmSettings.model default - Backend handler: hardcoded fallback in CreateSession - ambient-api-server: Session and Agent model defaults - Ungate claude-sonnet-4-6 (featureGated: false) since it is now default - Update test fixtures to reflect new default Closes #1264 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
This PR updates the default model for new agentic sessions from Source code changes:
Additional:
🤖 Session |
- models_test.go: Update Models[] index from [1] to [2] for claude-opus-4-6 after claude-sonnet-4-6 was inserted at index 1 - integration_test.go: Update TestSessionLlmDefaults assertion from "sonnet" to "claude-sonnet-4-6" to match new BeforeCreate default Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Update TestSessionLlmDefaults integration test to expect "claude-sonnet-4-6" instead of "sonnet" - Reorder test fixture model list to keep claude-opus-4-6 at index 1, preserving the "available=false" test that references Models[1] Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Pushed fix for CI failures:
The public-api Docker build failure ( 🤖 Session |
The pre-commit hook incorrectly changed Models[1] to Models[2]. With the reordered fixture list, claude-opus-4-6 remains at index 1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The runner's setup_sdk_authentication() had a hardcoded fallback to claude-sonnet-4-5 when LLM_MODEL is absent. While the operator always populates LLM_MODEL, this leaves a cross-component default inconsistent with models.json, sessions.go, and the ambient-api-server. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
jeremyeder
approved these changes
Apr 9, 2026
Contributor
jeremyeder
left a comment
jeremyeder
left a comment
There was a problem hiding this comment.
passed offline coderabbit and codex reviews and it works on my laptop
ambient-code bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
After rebase on main (which merged #1265), the test fixture had claude-sonnet-4-6 listed twice causing HaveLen(7) to fail with len 8. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude-sonnet-4-5toclaude-sonnet-4-6across all configuration layers (models.json, CRD schema, backend handler, ambient-api-server)claude-sonnet-4-6(featureGated: false) since it is now the default modelChanged Files
components/manifests/base/core/models.jsondefaultModelandproviderDefaults.anthropic→claude-sonnet-4-6; ungate modelcomponents/manifests/base/crds/agenticsessions-crd.yamlclaude-sonnet-4-6components/backend/handlers/sessions.goclaude-sonnet-4-6components/ambient-api-server/plugins/sessions/model.goclaude-sonnet-4-6components/ambient-api-server/plugins/agents/model.goclaude-sonnet-4-6components/backend/handlers/models_test.gocomponents/ambient-api-server/plugins/sessions/integration_test.gocomponents/frontend/.../__tests__/runner-model-selector.test.tsxcomponents/frontend/.../__tests__/new-session-view.test.tsxTest plan
Closes #1264
🤖 Generated with Claude Code
🤖 Ambient Session