fix(cli): improve contrast for dim phase rows in acpctl TUI#1578
Merged
Conversation
PhaseColor() was using color 240 (very dark gray) for idle, completed, cancelled, and default phases. This made entire table rows nearly invisible on dark terminal backgrounds. Bump to color 245 for readable contrast while still visually distinguishing inactive phases from active/running ones. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for cheerful-kitten-f556a0 canceled.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesSessions View Color Enhancement
🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Contributor
Merge Queue Status
This pull request spent 22 seconds in the queue, including 4 seconds running CI. Required conditions to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PhaseColor()used color240(very dark gray) for idle/completed/cancelled/default phases, making entire table rows nearly invisible on dark terminal backgrounds245(~60% gray) which is readable while still looking subdued compared to active/running phasesTest plan
acpctlTUI and verify idle/completed agent and session rows are readable on dark backgrounds🤖 Generated with Claude Code
Summary by CodeRabbit