Skip to content

fix(cli): improve contrast for dim phase rows in acpctl TUI#1578

Merged
mergify[bot] merged 1 commit into
mainfrom
fix/acpctl-dim-row-contrast
May 13, 2026
Merged

fix(cli): improve contrast for dim phase rows in acpctl TUI#1578
mergify[bot] merged 1 commit into
mainfrom
fix/acpctl-dim-row-contrast

Conversation

@jeremyeder
Copy link
Copy Markdown
Contributor

@jeremyeder jeremyeder commented May 13, 2026

Summary

  • PhaseColor() used color 240 (very dark gray) for idle/completed/cancelled/default phases, making entire table rows nearly invisible on dark terminal backgrounds
  • Bumped to color 245 (~60% gray) which is readable while still looking subdued compared to active/running phases

Test plan

  • Run acpctl TUI and verify idle/completed agent and session rows are readable on dark backgrounds
  • Verify active/running rows still stand out visually from idle rows

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Updated phase status colors in the terminal interface for improved visibility. Succeeded, completed, cancelled, idle, and default phase states now display with brighter coloring, enhancing readability and making status indicators more visually distinct during terminal operations.

PhaseColor() was using color 240 (very dark gray) for idle, completed,
cancelled, and default phases. This made entire table rows nearly
invisible on dark terminal backgrounds. Bump to color 245 for readable
contrast while still visually distinguishing inactive phases from
active/running ones.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jeremyeder jeremyeder added the ambient-code:self-reviewed Self-reviewed by Ambient agent label May 13, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 13, 2026

Deploy Preview for cheerful-kitten-f556a0 canceled.

Name Link
🔨 Latest commit 49bd097
🔍 Latest deploy log https://app.netlify.com/projects/cheerful-kitten-f556a0/deploys/6a04c1e3d132ef000858ded3

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: af98226d-e0fe-439f-9a11-58914527401b

📥 Commits

Reviewing files that changed from the base of the PR and between 824b2fa and 49bd097.

📒 Files selected for processing (1)
  • components/ambient-cli/cmd/acpctl/ambient/tui/views/sessions.go

📝 Walkthrough

Walkthrough

The PhaseColor function in the sessions TUI view is updated to return a brighter light-gray color (245) for succeeded, cancelled, and default cases instead of dim gray (240), leaving other phase colors unchanged.

Changes

Sessions View Color Enhancement

Layer / File(s) Summary
Phase color mapping update
components/ambient-cli/cmd/acpctl/ambient/tui/views/sessions.go
PhaseColor returns lighter gray (245) for succeeded, cancelled, and default phases instead of (240), improving visual contrast while preserving colors for pending (yellow), running (orange), and failed (red).
🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title follows Conventional Commits format with 'fix(cli):' prefix and clearly describes the main change: improving contrast for dim phase rows in the acpctl TUI.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity ✅ Passed PR only changes a color constant (240→245) in a simple O(1) switch statement. No algorithmic changes, loops, API calls, caching, or resource-intensive operations introduced. Pure UI styling update.
Security And Secret Handling ✅ Passed PR updates PhaseColor() with color 240→245 for UI contrast. No secrets, injection vulnerabilities, auth issues, or sensitive data detected.
Kubernetes Resource Safety ✅ Passed PR modifies only TUI color rendering in sessions.go (Go source code). Contains no Kubernetes manifests, RBAC policies, container definitions, or resource configurations—the check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/acpctl-dim-row-contrast
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/acpctl-dim-row-contrast

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify Bot added the queued label May 13, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 13, 2026

Merge Queue Status

  • Entered queue2026-05-13 18:34 UTC · Rule: default
  • Checks skipped · PR is already up-to-date
  • Merged2026-05-13 18:34 UTC · at 49bd09781443792981aec58bf570bad1a7cdf9f5 · squash

This pull request spent 22 seconds in the queue, including 4 seconds running CI.

Required conditions to merge

@mergify mergify Bot merged commit 333aeb1 into main May 13, 2026
38 checks passed
@mergify mergify Bot deleted the fix/acpctl-dim-row-contrast branch May 13, 2026 18:34
@mergify mergify Bot removed the queued label May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ambient-code:self-reviewed Self-reviewed by Ambient agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant