Skip to content

remove duplicate AutoPushOnComplete#173

Merged
sallyom merged 1 commit intoambient-code:mainfrom
sallyom:fix-autopush
Oct 13, 2025
Merged

remove duplicate AutoPushOnComplete#173
sallyom merged 1 commit intoambient-code:mainfrom
sallyom:fix-autopush

Conversation

@sallyom
Copy link
Copy Markdown
Contributor

@sallyom sallyom commented Oct 12, 2025

@Gkrumbach07 with the rebase I had this defined in 2 places - it should only be here - the duplicate was causing issues - I hope this fixes it, testing now.

@sallyom sallyom force-pushed the fix-autopush branch 3 times, most recently from eca14f5 to 747d9c1 Compare October 13, 2025 01:34
commit 808a026 was lost in the refactor

Signed-off-by: sallyom <somalley@redhat.com>
@sallyom sallyom force-pushed the fix-autopush branch 2 times, most recently from e3c2489 to 5811313 Compare October 13, 2025 03:57
@sallyom
Copy link
Copy Markdown
Contributor Author

sallyom commented Oct 13, 2025

@cooktheryan @Gkrumbach07
I've tested this and the auto-push is fixed - however I needed to build the new operator image.
Maybe quay.io/ambient_code/vteam_operator:latest isn't up-to-date with latest operator code?
I have confirmed from testing that quay.io/ambient_code/vteam_operator:latest does not set the AUTO_PUSH_ON_COMPLETE env var in the agenticsession jobs. Only when I build the operator from latest code does that get set. However, I'm not changing any operator code here, so the ambient_code/vteam_operator:latest must not have the latest code.

@sallyom
Copy link
Copy Markdown
Contributor Author

sallyom commented Oct 13, 2025

merging this fix!

@sallyom sallyom merged commit 0e8efbe into ambient-code:main Oct 13, 2025
sallyom added a commit that referenced this pull request Oct 15, 2025
@Gkrumbach07 with the rebase I had this defined in 2 places - it should
_only_ be
[here](https://github.com/ambient-code/vTeam/blob/main/components/backend/types/session.go#L74)
- the duplicate was causing issues - I hope this fixes it, testing now.

Signed-off-by: sallyom <somalley@redhat.com>
@sallyom sallyom deleted the fix-autopush branch October 17, 2025 02:07
@bobbravo2 bobbravo2 added this to the v0.0.3 milestone Jan 30, 2026
jeremyeder added a commit that referenced this pull request Apr 10, 2026
## Summary

- Bump `next` 16.2.2 → 16.2.3 — fixes DoS via Server Components (alert
#173)
- Bump `aiohttp` ≥3.13.3 → ≥3.13.4 — fixes 9 CVEs: header injection,
SSRF, DoS, credential leak, CRLF injection (alerts #149–158)
- Bump `cryptography` 46.0.5 → 46.0.7 (transitive) — fixes buffer
overflow (alert #172)
- Bump `lupa` 2.6 → 2.7 (transitive) — fixes sandbox escape / RCE (alert
#168)

### Remaining alerts (3)

Alerts #144, #145, #146 (`fastmcp` 2.14.3 → 3.2.0) are **blocked on
upstream**: `mcp-atlassian` 0.21.1 pins `fastmcp<2.15.0,>=2.13.0`. The
CVEs affect fastmcp's OpenAPI provider and OAuth proxy — not in our code
path, but the alerts will stay open until `mcp-atlassian` releases a
version compatible with fastmcp 3.x.

## Test plan

- [x] Frontend: 614 tests pass (`npx vitest run`)
- [x] Runner: 543 tests pass (`uv run pytest tests/`)
- [ ] CI passes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Chores**
* Bumped frontend and runtime dependency minimums to newer patch
releases.

* **Refactor**
* Code formatting and parameter/layout reflows across several modules
for readability.

* **Tests**
* Cleaned up and reformatted unit tests, removing unused imports and
improving fixture readability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Ambient Code Bot <bot@ambient-code.local>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants