Skip to content

Fixes Issue #199: Remove redundant back buttons from RFE and session pages #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

Fixes Issue #199: Remove redundant back buttons from RFE and session pages #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion components/frontend/src/app/projects/[name]/rfe/[id]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@
}
);
});
}, [project, id, updateWorkflowMutation, load, refetchSeeding]);

Check warning on line 203 in components/frontend/src/app/projects/[name]/rfe/[id]/page.tsx

View workflow job for this annotation

GitHub Actions / lint-frontend 

React Hook useCallback has a missing dependency: 'seedWorkflowMutation'. Either include it or remove the dependency array


if (loading) return (
Expand Down Expand Up @@ -251,7 +251,6 @@
/>
<RfeHeader
workflow={workflow}
projectName={project}
deleting={deleteWorkflowMutation.isPending}
onDelete={deleteWorkflow}
/>
Expand Down
20 changes: 5 additions & 15 deletions components/frontend/src/app/projects/[name]/rfe/[id]/rfe-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,21 @@
"use client";

import Link from "next/link";
import { Button } from "@/components/ui/button";
import { ArrowLeft, Loader2, Trash2 } from "lucide-react";
import { Loader2, Trash2 } from "lucide-react";
import type { RFEWorkflow } from "@/types/agentic-session";

type RfeHeaderProps = {
workflow: RFEWorkflow;
projectName: string;
deleting: boolean;
onDelete: () => Promise<void>;
};

export function RfeHeader({ workflow, projectName, deleting, onDelete }: RfeHeaderProps) {
export function RfeHeader({ workflow, deleting, onDelete }: RfeHeaderProps) {
return (
<div className="flex items-start justify-between">
<div className="flex items-center gap-4">
<Link href={`/projects/${encodeURIComponent(projectName)}/rfe`}>
<Button variant="ghost" size="sm">
<ArrowLeft className="h-4 w-4 mr-2" />
Back to RFE Workspaces
</Button>
</Link>
<div>
<h1 className="text-3xl font-bold">{workflow.title}</h1>
<p className="text-muted-foreground mt-1">{workflow.description}</p>
</div>
<div>
<h1 className="text-3xl font-bold">{workflow.title}</h1>
<p className="text-muted-foreground mt-1">{workflow.description}</p>
</div>
<Button variant="destructive" size="sm" onClick={onDelete} disabled={deleting}>
{deleting ? (
Expand Down
16 changes: 4 additions & 12 deletions components/frontend/src/app/projects/[name]/rfe/new/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { useForm, useFieldArray } from 'react-hook-form';
import { zodResolver } from '@hookform/resolvers/zod';
import * as z from 'zod';
import Link from 'next/link';
import { ArrowLeft, Loader2, GitBranch } from 'lucide-react';
import { Loader2, GitBranch } from 'lucide-react';

import { Button } from '@/components/ui/button';
import { Card, CardContent, CardDescription, CardHeader, CardTitle } from '@/components/ui/card';
Expand Down Expand Up @@ -164,17 +164,9 @@ export default function ProjectNewRFEWorkflowPage() {
]}
className="mb-4"
/>
<div className="flex items-center gap-4 mb-8">
<Link href={`/projects/${encodeURIComponent(projectName)}/rfe`}>
<Button variant="ghost" size="sm">
<ArrowLeft className="h-4 w-4 mr-2" />
Back to RFE Workspaces
</Button>
</Link>
<div>
<h1 className="text-3xl font-bold">Create RFE Workspace</h1>
<p className="text-muted-foreground">Set up a new Request for Enhancement workflow with AI agents</p>
</div>
<div className="mb-8">
<h1 className="text-3xl font-bold">Create RFE Workspace</h1>
<p className="text-muted-foreground">Set up a new Request for Enhancement workflow with AI agents</p>
</div>

{/* Error state from mutation */}
Expand Down
8 changes: 0 additions & 8 deletions components/frontend/src/app/projects/[name]/sessions/[sessionName]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,14 +702,6 @@ export default function ProjectSessionDetailPage({
]}
className="mb-4"
/>
<div className="flex items-center justify-start mb-6">
<Link href={backHref || `/projects/${encodeURIComponent(projectName)}/sessions`}>
<Button variant="ghost" size="sm">
<ArrowLeft className="w-4 h-4 mr-2" />
{backLabel || "Back to Sessions"}
</Button>
</Link>
</div>

<div className="space-y-6">
{/* Header */}
Expand Down
10 changes: 1 addition & 9 deletions components/frontend/src/app/projects/[name]/sessions/new/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import { useEffect, useState } from "react";
import { useRouter, useSearchParams } from "next/navigation";
import Link from "next/link";
import { ArrowLeft, Loader2 } from "lucide-react";
import { Loader2 } from "lucide-react";
import { useForm, useFieldArray } from "react-hook-form";
import { zodResolver } from "@hookform/resolvers/zod";
import * as z from "zod";
Expand Down Expand Up @@ -200,14 +200,6 @@ export default function NewProjectSessionPage({ params }: { params: Promise<{ na
]}
className="mb-4"
/>
<div className="flex items-center mb-6">
<Link href={`/projects/${encodeURIComponent(projectName)}/sessions`}>
<Button variant="ghost" size="sm">
<ArrowLeft className="w-4 h-4 mr-2" />
Back to Sessions
</Button>
</Link>
</div>

<Card>
<CardHeader>
Expand Down
Loading