fix: add missing backend env vars to GH Actions workflow patches #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem:** The workflow uses `oc patch` with "op": "replace" to update env vars, which completely overwrites the env array. Any env vars added to the backend-deployment.yaml manifest but not in the workflow patch get deleted. **Missing env vars:** - CLAUDE_CODE_USE_VERTEX (from ConfigMap operator-config) - OOTB_WORKFLOWS_REPO - OOTB_WORKFLOWS_BRANCH - OOTB_WORKFLOWS_PATH These were defined in components/manifests/base/backend-deployment.yaml but missing from the hardcoded patch list, causing them to be removed after deployment. **Why this pattern exists:** The workflow needs to inject dynamic values like image tags from the build. However, using "replace" instead of "add" or selective patching creates drift between manifests (source of truth) and actual deployments. **Better long-term solution:** Use kustomize to handle dynamic env vars (like VTEAM_VERSION) instead of post-deployment patching. This would eliminate the need to maintain two copies of env var lists. **Changes:** - Added missing env vars to both deploy jobs (deploy-to-openshift and deploy-with-dispatch) - Backend deployments will now include all env vars from the manifest Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: sallyom <somalley@redhat.com>
jeremyeder
pushed a commit
to jeremyeder/platform
that referenced
this pull request
Nov 12, 2025
…ient-code#284) **Problem:** The workflow uses `oc patch` with "op": "replace" to update env vars, which completely overwrites the env array. Any env vars added to the backend-deployment.yaml manifest but not in the workflow patch get deleted. **Missing env vars:** - CLAUDE_CODE_USE_VERTEX (from ConfigMap operator-config) - OOTB_WORKFLOWS_REPO - OOTB_WORKFLOWS_BRANCH - OOTB_WORKFLOWS_PATH These were defined in components/manifests/base/backend-deployment.yaml but missing from the hardcoded patch list, causing them to be removed after deployment. **Why this pattern exists:** The workflow needs to inject dynamic values like image tags from the build. However, using "replace" instead of "add" or selective patching creates drift between manifests (source of truth) and actual deployments. **Better long-term solution:** Use kustomize to handle dynamic env vars (like VTEAM_VERSION) instead of post-deployment patching. This would eliminate the need to maintain two copies of env var lists. **Changes:** - Added missing env vars to both deploy jobs (deploy-to-openshift and deploy-with-dispatch) - Backend deployments will now include all env vars from the manifest Signed-off-by: sallyom <somalley@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The workflow uses
oc patchwith "op": "replace" to update env vars, which completely overwrites the env array. Any env vars added to the backend-deployment.yaml manifest but not in the workflow patch get deleted.Missing env vars:
These were defined in components/manifests/base/backend-deployment.yaml but missing from the hardcoded patch list, causing them to be removed after deployment.
Why this pattern exists:
The workflow needs to inject dynamic values like image tags from the build. However, using "replace" instead of "add" or selective patching creates drift between manifests (source of truth) and actual deployments.
Better long-term solution:
Use kustomize to handle dynamic env vars (like VTEAM_VERSION) instead of post-deployment patching. This would eliminate the need to maintain two copies of env var lists.
Changes: