Skip to content

fix: remove backend-ingress to resolve auth token routing conflict #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove backend-ingress to resolve auth token routing conflict #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/manifests/overlays/e2e/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ resources:
- secrets.yaml
- test-user.yaml
- frontend-ingress.yaml
- backend-ingress.yaml
# backend-ingress.yaml removed - frontend handles all routing and proxies to backend internally
Comment on lines 11 to +12
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Removing backend ingress never cleans up existing deployments

Commenting out backend-ingress.yaml from the e2e kustomization prevents new deployments from creating the ingress, but e2e/scripts/deploy.sh still uses kubectl apply -k without --prune. Any cluster that previously deployed this overlay will keep the old backend-ingress resource, so /api requests will continue to bypass the frontend and the “Invalid or missing token” problem remains. The fix only works on brand‑new clusters. Consider deleting the old ingress explicitly or switching to a pruned apply so existing environments also receive the change.

Useful? React with 👍 / 👎.

Copy link
Contributor

@github-actions github-actions bot Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation Enhancement Suggestion

Great explanatory comment! To make it even more helpful for future developers, consider adding a reference to where this architectural pattern is documented:

Suggested change
# backend-ingress.yaml removed - frontend handles all routing and proxies to backend internally
# backend-ingress.yaml removed - frontend handles all routing and proxies to backend internally
# Architecture: Next.js API Gateway pattern - see components/frontend/src/lib/auth.ts for auth flow

This helps developers understand where to look for the authentication/proxy implementation details.

- operator-config.yaml

# Patches for e2e environment
Expand Down
Loading